github-actions[bot] commented on code in PR #25147:
URL: https://github.com/apache/doris/pull/25147#discussion_r1360450061
##########
be/src/olap/txn_manager.cpp:
##########
@@ -175,11 +176,11 @@ Status TxnManager::delete_txn(TPartitionId partition_id,
const TabletSharedPtr&
tablet->tablet_id(), tablet->tablet_uid());
}
-void TxnManager::set_txn_related_delete_bitmap(TPartitionId partition_id,
- TTransactionId transaction_id,
TTabletId tablet_id,
- TabletUid tablet_uid, bool
unique_key_merge_on_write,
- DeleteBitmapPtr delete_bitmap,
- const RowsetIdUnorderedSet&
rowset_ids) {
+void TxnManager::set_txn_related_delete_bitmap(
Review Comment:
warning: method 'set_txn_related_delete_bitmap' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void TxnManager::set_txn_related_delete_bitmap(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
