yiguolei commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1361399663
##########
be/src/olap/predicate_creator.h:
##########
@@ -203,36 +257,76 @@ std::unique_ptr<PredicateCreator<ConditionType>>
get_creator(const FieldType& ty
return std::make_unique<StringPredicateCreator<TYPE_STRING, PT,
ConditionType>>();
}
case FieldType::OLAP_FIELD_TYPE_DATE: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATE, PT,
ConditionType>>(
- timestamp_from_date);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATE, PT,
ConditionType>>(
+ timestamp_from_date);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATE, PT,
ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
+ });
+ }
}
case FieldType::OLAP_FIELD_TYPE_DATEV2: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATEV2, PT,
ConditionType>>(
- timestamp_from_date_v2);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATEV2, PT,
ConditionType>>(
+ timestamp_from_date_v2);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATEV2, PT,
ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
+ });
+ }
}
case FieldType::OLAP_FIELD_TYPE_DATETIME: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATETIME, PT,
ConditionType>>(
- timestamp_from_datetime);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIME, PT,
ConditionType>>(
+ timestamp_from_datetime);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIME, PT,
ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
+ });
+ }
}
case FieldType::OLAP_FIELD_TYPE_DATETIMEV2: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATETIMEV2, PT,
ConditionType>>(
- timestamp_from_datetime_v2);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIMEV2,
PT, ConditionType>>(
+ timestamp_from_datetime_v2);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIMEV2,
PT, ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
Review Comment:
uint32 ？？？
##########
be/src/olap/predicate_creator.h:
##########
@@ -203,36 +257,76 @@ std::unique_ptr<PredicateCreator<ConditionType>>
get_creator(const FieldType& ty
return std::make_unique<StringPredicateCreator<TYPE_STRING, PT,
ConditionType>>();
}
case FieldType::OLAP_FIELD_TYPE_DATE: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATE, PT,
ConditionType>>(
- timestamp_from_date);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATE, PT,
ConditionType>>(
+ timestamp_from_date);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATE, PT,
ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
+ });
+ }
}
case FieldType::OLAP_FIELD_TYPE_DATEV2: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATEV2, PT,
ConditionType>>(
- timestamp_from_date_v2);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATEV2, PT,
ConditionType>>(
+ timestamp_from_date_v2);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATEV2, PT,
ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
+ });
+ }
}
case FieldType::OLAP_FIELD_TYPE_DATETIME: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATETIME, PT,
ConditionType>>(
- timestamp_from_datetime);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIME, PT,
ConditionType>>(
+ timestamp_from_datetime);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIME, PT,
ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
+ });
+ }
}
case FieldType::OLAP_FIELD_TYPE_DATETIMEV2: {
- return std::make_unique<CustomPredicateCreator<TYPE_DATETIMEV2, PT,
ConditionType>>(
- timestamp_from_datetime_v2);
+ if constexpr (std::is_same_v<std::string, ConditionType> ||
+ std::is_same_v<std::vector<std::string>, ConditionType>)
{
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIMEV2,
PT, ConditionType>>(
+ timestamp_from_datetime_v2);
+ } else {
+ return std::make_unique<CustomPredicateCreator<TYPE_DATETIMEV2,
PT, ConditionType>>(
+ [](const void* const& condition) {
+ return *reinterpret_cast<const uint32_t*>(condition);
Review Comment:
uint32 ？？？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
