github-actions[bot] commented on code in PR #25524:
URL: https://github.com/apache/doris/pull/25524#discussion_r1361728413
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -951,6 +951,14 @@ void FragmentMgr::_set_scan_concurrency(const Param&
params, QueryContext* query
#endif
}
+bool FragmentMgr::is_pipeline_fragment(const TUniqueId& id) {
Review Comment:
warning: method 'is_pipeline_fragment' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool FragmentMgr::is_pipeline_fragment(const TUniqueId& id) {
```
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -951,6 +951,14 @@ void FragmentMgr::_set_scan_concurrency(const Param&
params, QueryContext* query
#endif
}
+bool FragmentMgr::is_pipeline_fragment(const TUniqueId& id) {
+ std::unique_lock<std::mutex> state_lock(_lock);
+ if (_pipeline_map.contains(id)) {
+ return true;
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/runtime/fragment_mgr.cpp:955:
```diff
- if (_pipeline_map.contains(id)) {
- return true;
- }
- return false;
+ return _pipeline_map.contains(id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
