zddr commented on code in PR #25364:
URL: https://github.com/apache/doris/pull/25364#discussion_r1366379462
##########
fe/be-java-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonTypeUtils.java:
##########
@@ -153,7 +177,10 @@ public PaimonColumnType visit(LocalZonedTimestampType
localZonedTimestampType) {
@Override
public PaimonColumnType visit(ArrayType arrayType) {
- return this.defaultMethod(arrayType);
+ PaimonColumnType paimonColumnType = new
PaimonColumnType(Type.ARRAY);
+ ColumnType elementColumnType = fromPaimonType("element",
arrayType.getElementType());
Review Comment:
why is "element"?
##########
regression-test/suites/external_table_p0/paimon/test_paimon_catalog.groovy:
##########
@@ -72,10 +72,14 @@ suite("test_paimon_catalog",
"p0,external,doris,external_docker,external_docker_
def c15 = """select * from all_table where c15='a';"""
def c16 = """select * from all_table where c16=true;"""
def c18 = """select * from all_table where c18='2023-08-13
09:32:38.53';"""
- def c19 = """select * from auto_bucket;"""
+ def c19 = """select * from auto_bucket order by user_id;"""
def c20 = """select * from auto_bucket where dt="b";"""
def c21 = """select * from auto_bucket where dt="b" and hh="c";"""
def c22 = """select * from auto_bucket where dt="d";"""
+ def c23 = """select * from complex_tab order by c1;"""
+ def c24 = """select * from complex_tab where c1=1;"""
Review Comment:
24,25,26 is similar，keeping one is enough,can add some case like 'SELECT
m['a'] FROM simple_map;'
##########
regression-test/suites/external_table_p0/paimon/test_paimon_catalog.groovy:
##########
@@ -72,10 +72,14 @@ suite("test_paimon_catalog",
"p0,external,doris,external_docker,external_docker_
def c15 = """select * from all_table where c15='a';"""
def c16 = """select * from all_table where c16=true;"""
def c18 = """select * from all_table where c18='2023-08-13
09:32:38.53';"""
- def c19 = """select * from auto_bucket;"""
+ def c19 = """select * from auto_bucket order by user_id;"""
def c20 = """select * from auto_bucket where dt="b";"""
def c21 = """select * from auto_bucket where dt="b" and hh="c";"""
def c22 = """select * from auto_bucket where dt="d";"""
+ def c23 = """select * from complex_tab order by c1;"""
+ def c24 = """select * from complex_tab where c1=1;"""
Review Comment:
24,25,26 is similar，keeping one is enough,can add some case like 'SELECT
m['a'] FROM simple_map;'
##########
fe/be-java-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonTypeUtils.java:
##########
@@ -184,6 +227,7 @@ private static class PaimonColumnType {
private int length;
private int precision;
private int scale;
+ private List<PaimonColumnType> childTypes;
Review Comment:
change to ColumnType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
