github-actions[bot] commented on code in PR #25725:
URL: https://github.com/apache/doris/pull/25725#discussion_r1368223610
##########
be/src/vec/columns/column_struct.h:
##########
@@ -82,6 +82,7 @@ class ColumnStruct final : public COWHelper<IColumn,
ColumnStruct> {
}
std::string get_name() const override;
+ bool is_column_struct() const override { return true; }
Review Comment:
warning: method 'is_column_struct' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool is_column_struct() override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
