yiguolei commented on code in PR #25524:
URL: https://github.com/apache/doris/pull/25524#discussion_r1368393738
##########
be/src/service/internal_service.cpp:
##########
@@ -558,15 +558,19 @@ void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
tid.__set_lo(request->finst_id().lo());
signal::set_signal_task_id(tid);
Status st = Status::OK();
- if (request->has_cancel_reason()) {
- LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid)
- << ", reason: " <<
PPlanFragmentCancelReason_Name(request->cancel_reason());
- _exec_env->fragment_mgr()->cancel_instance(tid,
request->cancel_reason());
- } else {
- LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid);
- _exec_env->fragment_mgr()->cancel_instance(tid,
-
PPlanFragmentCancelReason::INTERNAL_ERROR);
- }
+
+ const bool is_pipeline_fragment =
_exec_env->fragment_mgr()->is_pipeline_fragment(tid);
Review Comment:
把这个方法删了吧，加一个pipeline的前缀意义不大
可以在cancel insantance unlock 里面加pipeline的信息
##########
be/src/service/internal_service.cpp:
##########
@@ -558,15 +558,19 @@ void
PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*
tid.__set_lo(request->finst_id().lo());
signal::set_signal_task_id(tid);
Status st = Status::OK();
- if (request->has_cancel_reason()) {
- LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid)
- << ", reason: " <<
PPlanFragmentCancelReason_Name(request->cancel_reason());
- _exec_env->fragment_mgr()->cancel_instance(tid,
request->cancel_reason());
- } else {
- LOG(INFO) << "cancel fragment, fragment_instance_id=" <<
print_id(tid);
- _exec_env->fragment_mgr()->cancel_instance(tid,
-
PPlanFragmentCancelReason::INTERNAL_ERROR);
- }
+
+ const bool is_pipeline_fragment =
_exec_env->fragment_mgr()->is_pipeline_fragment(tid);
Review Comment:
把这个方法删了吧，加一个pipeline的前缀意义不大
可以在cancel insantance unlock 里面加pipeline的信息
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
