github-actions[bot] commented on code in PR #25881:
URL: https://github.com/apache/doris/pull/25881#discussion_r1371229276
##########
be/src/pipeline/pipeline_x/dependency.h:
##########
@@ -161,15 +162,15 @@ class FinishDependency final : public Dependency {
_finish_dependency_watcher.start();
}
- [[nodiscard]] virtual int64_t finish_watcher_elapse_time() {
+ [[nodiscard]] int64_t finish_watcher_elapse_time() {
return _finish_dependency_watcher.elapsed_time();
}
- [[nodiscard]] virtual FinishDependency* finish_blocked_by() {
+ [[nodiscard]] FinishDependency* finish_blocked_by() {
Review Comment:
warning: method 'finish_blocked_by' can be made static
[readability-convert-member-functions-to-static]
```suggestion
[[nodiscard]] static FinishDependency* finish_blocked_by() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
