JNSimba commented on code in PR #219:
URL:
https://github.com/apache/doris-flink-connector/pull/219#discussion_r1375357421
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDatabaseSync.java:
##########
@@ -59,9 +59,24 @@
public class OracleDatabaseSync extends DatabaseSync {
private static final Logger LOG =
LoggerFactory.getLogger(OracleDatabaseSync.class);
- private static String JDBC_URL = "jdbc:oracle:thin:@%s:%d:%s";
+ private static final String JDBC_URL = "jdbc:oracle:thin:@%s:%d:%s";
- public OracleDatabaseSync() {
+ public OracleDatabaseSync() throws SQLException {
+ super();
+ }
+
+ @Override
+ public void registerDriver() throws SQLException {
+ try {
+ Class.forName("oracle.jdbc.driver.OracleDriver");
+ } catch (ClassNotFoundException ex) {
+ LOG.warn("can not found class oracle.jdbc.driver.OracleDriver, use
class oracle.jdbc.OracleDriver");
+ try {
+ Class.forName("com.mysql.jdbc.Driver");
Review Comment:
This should be the oracle driver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
