HappenLee commented on code in PR #25979:
URL: https://github.com/apache/doris/pull/25979#discussion_r1375963880
##########
be/src/vec/sink/writer/vtablet_writer.cpp:
##########
@@ -1737,34 +1740,37 @@ Status
VTabletWriter::append_block(doris::vectorized::Block& input_block) {
missing_map.reserve(partition_col.column->size());
// try to find tablet and save missing value
- for (int i = 0; i < num_rows; ++i) {
- if (UNLIKELY(has_filtered_rows) &&
_block_convertor->filter_map()[i]) {
- continue;
+ std::vector<VOlapTablePartition*> partitions {num_rows, nullptr};
Review Comment:
the code should be simple and same as not auto parttition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
