Lchangliang commented on code in PR #26319:
URL: https://github.com/apache/doris/pull/26319#discussion_r1381198510
##########
be/src/exec/tablet_info.cpp:
##########
@@ -92,8 +91,9 @@ Status OlapTableSchemaParam::init(const
POlapTableSchemaParam& pschema) {
for (auto& pcolumn_desc : p_index.columns_desc()) {
if (!_is_partial_update ||
_partial_update_input_columns.count(pcolumn_desc.name()) > 0) {
- std::string col_type = has_invalid_type ? "INVALID_TYPE" :
pcolumn_desc.type();
Review Comment:
Can't remove this
##########
be/src/exec/tablet_info.cpp:
##########
@@ -69,19 +69,18 @@ Status OlapTableSchemaParam::init(const
POlapTableSchemaParam& pschema) {
for (auto& col : pschema.partial_update_input_columns()) {
_partial_update_input_columns.insert(col);
}
- std::unordered_map<std::pair<std::string, std::string>, SlotDescriptor*>
slots_map;
+ std::unordered_map<std::pair<std::string, FieldType>, SlotDescriptor*>
slots_map;
_tuple_desc = _obj_pool.add(new TupleDescriptor(pschema.tuple_desc()));
// When FE version is less than 2.0.3, But BE upgrade to 2.0.3,
// the filed col_type in slot_desc is INVALID_TYPE default.
// It can be remove later.
- bool has_invalid_type = false;
for (auto& p_slot_desc : pschema.slot_descs()) {
auto slot_desc = _obj_pool.add(new SlotDescriptor(p_slot_desc));
- if (slot_desc->col_type() == INVALID_TYPE) has_invalid_type = true;
Review Comment:
Can't remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
