This is an automated email from the ASF dual-hosted git repository.
kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 48d1feff523 [coverage](pipeline) Remove unless code and add call
method for coverage #25552 (#26423)
48d1feff523 is described below
commit 48d1feff5233a2df538736aed84bdef7c3e5dce1
Author: HappenLee <[email protected]>
AuthorDate: Sat Nov 4 15:43:23 2023 +0800
[coverage](pipeline) Remove unless code and add call method for coverage
#25552 (#26423)
Remove unless code and add call method for coverage
---
be/src/pipeline/exec/exchange_sink_operator.h | 2 --
be/src/pipeline/exec/multi_cast_data_stream_sink.h | 2 +-
be/src/util/proto_util.h | 4 +---
be/src/vec/sink/vdata_stream_sender.cpp | 2 +-
4 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/be/src/pipeline/exec/exchange_sink_operator.h
b/be/src/pipeline/exec/exchange_sink_operator.h
index 0ebb8b3e9e7..cbce047fb81 100644
--- a/be/src/pipeline/exec/exchange_sink_operator.h
+++ b/be/src/pipeline/exec/exchange_sink_operator.h
@@ -60,8 +60,6 @@ public:
Status close(RuntimeState* state) override;
- RuntimeState* state() { return _state; }
-
private:
std::unique_ptr<ExchangeSinkBuffer> _sink_buffer;
int _dest_node_id = -1;
diff --git a/be/src/pipeline/exec/multi_cast_data_stream_sink.h
b/be/src/pipeline/exec/multi_cast_data_stream_sink.h
index e137a7e6558..1a2480782f4 100644
--- a/be/src/pipeline/exec/multi_cast_data_stream_sink.h
+++ b/be/src/pipeline/exec/multi_cast_data_stream_sink.h
@@ -37,7 +37,7 @@ public:
MultiCastDataStreamSinkOperator(OperatorBuilderBase* operator_builder,
DataSink* sink)
: DataSinkOperator(operator_builder, sink) {}
- bool can_write() override { return true; }
+ bool can_write() override { return _sink->can_write(); }
};
OperatorPtr MultiCastDataStreamSinkOperatorBuilder::build_operator() {
diff --git a/be/src/util/proto_util.h b/be/src/util/proto_util.h
index 3c583b867cc..bdbbf8cc94d 100644
--- a/be/src/util/proto_util.h
+++ b/be/src/util/proto_util.h
@@ -45,9 +45,7 @@ Status request_embed_attachment_contain_block(Params*
brpc_request, Closure* clo
return st;
}
-inline bool enable_http_send_block(
- const PTransmitDataParams& request,
- bool transfer_large_data_by_brpc =
config::transfer_large_data_by_brpc) {
+inline bool enable_http_send_block(const PTransmitDataParams& request) {
if (!config::transfer_large_data_by_brpc) {
return false;
}
diff --git a/be/src/vec/sink/vdata_stream_sender.cpp
b/be/src/vec/sink/vdata_stream_sender.cpp
index 42ceb04aea7..ea8837a9227 100644
--- a/be/src/vec/sink/vdata_stream_sender.cpp
+++ b/be/src/vec/sink/vdata_stream_sender.cpp
@@ -185,7 +185,7 @@ Status Channel::send_block(PBlock* block, bool eos) {
{
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(ExecEnv::GetInstance()->orphan_mem_tracker());
- if (enable_http_send_block(_brpc_request,
_parent->_transfer_large_data_by_brpc)) {
+ if (enable_http_send_block(_brpc_request)) {
RETURN_IF_ERROR(transmit_block_http(_state, _closure,
_brpc_request, _brpc_dest_addr));
} else {
transmit_block(*_brpc_stub, _closure, _brpc_request);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
