yiguolei commented on code in PR #26191:
URL: https://github.com/apache/doris/pull/26191#discussion_r1386189902
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -416,37 +416,10 @@ struct FixedStringFindOp : public StringFindOp {
}
};
-struct DateTimeFindOp : public CommonFindOp<VecDateTimeValue> {
- bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const {
- VecDateTimeValue value;
- value.from_olap_datetime(*reinterpret_cast<const uint64_t*>(data));
- return bloom_filter.test(Slice((char*)&value,
sizeof(VecDateTimeValue)));
- }
-};
-
-// avoid violating C/C++ aliasing rules.
-// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101684
-
-struct DateFindOp : public CommonFindOp<VecDateTimeValue> {
- bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const {
- uint24_t date = *static_cast<const uint24_t*>(data);
- uint64_t value = uint32_t(date);
-
- VecDateTimeValue date_value;
- date_value.from_olap_date(value);
-
- return bloom_filter.test(Slice((char*)&date_value,
sizeof(VecDateTimeValue)));
- }
-};
-
struct DecimalV2FindOp : public CommonFindOp<DecimalV2Value> {
bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const {
- auto packed_decimal = *static_cast<const decimal12_t*>(data);
- DecimalV2Value value;
- int64_t int_value = packed_decimal.integer;
- int32_t frac_value = packed_decimal.fraction;
- value.from_olap_decimal(int_value, frac_value);
-
+ // Predicate column using decimalv2value as column value type, so not
need convert here
+ DecimalV2Value value = *static_cast<const DecimalV2Value*>(data);
Review Comment:
Could we delete DecimalV2FindOp??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
