yujun777 commented on code in PR #26428:
URL: https://github.com/apache/doris/pull/26428#discussion_r1387394834
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1111,8 +1114,28 @@ public void finishTransaction(long transactionId) throws
UserException {
LOG.info("finish transaction {} successfully, publish result: {}",
transactionState, publishResult.name());
}
- private void checkReplicaContinuousVersionSucc(long tabletId, Replica
replica, long version,
- PublishVersionTask backendPublishTask, Set<Long> errorReplicaIds,
List<Replica> tabletSuccReplicas,
+ private boolean isCheckTxnIgnoreAlterReplica(long transactionId, OlapTable
table) {
Review Comment:
updated
##########
be/src/olap/task/engine_publish_version_task.cpp:
##########
@@ -235,7 +236,19 @@ Status EnginePublishVersionTask::finish() {
} else {
// check if the version exist, if not exist, then set publish
failed
if (_error_tablet_ids->find(tablet_id) ==
_error_tablet_ids->end()) {
- if (tablet->check_version_exist(version)) {
+ bool exist_version = tablet->check_version_exist(version);
+ bool is_converting = false;
+ if (!exist_version && tablet->tablet_state() ==
TabletState::TABLET_NOTREADY) {
+ bool is_mow = tablet->keys_type() ==
KeysType::UNIQUE_KEYS &&
Review Comment:
remove be code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
