morningman commented on a change in pull request #5366:
URL: https://github.com/apache/incubator-doris/pull/5366#discussion_r570993116



##########
File path: 
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
##########
@@ -32,17 +32,15 @@
 import static 
org.apache.doris.spark.util.ErrorMessages.SHOULD_NOT_HAPPEN_MESSAGE;
 
 import java.io.IOException;
+import java.io.InputStream;
+import java.io.PrintWriter;
 import java.io.Serializable;
+import java.net.HttpURLConnection;
+import java.net.URL;
 import java.nio.charset.StandardCharsets;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;

Review comment:
       Better not using `import *`

##########
File path: 
extension/spark-doris-connector/src/test/scala/org/apache/doris/spark/sql/SparkDorisConnector.scala
##########
@@ -0,0 +1,30 @@
+package org.apache.doris.spark.sql
+
+import org.apache.spark.{SparkConf, SparkContext}
+
+
+
+object SparkDorisConnector {
+
+    def main(args: Array[String]): Unit = {
+        val sparkConf: SparkConf = new 
SparkConf().setAppName("SparkDorisConnector").setMaster("local[*]")
+        val sc = new SparkContext(sparkConf)
+        sc.setLogLevel("DEBUG")
+        import org.apache.doris.spark._
+        val dorisSparkRDD = sc.dorisRDD(
+//            tableIdentifier = Some("ods.ods_pos_pro_shop_delta"),
+            tableIdentifier = Some("ods.ods_t_pro_dish_list_detail_test_demo"),
+//            query = Some("select * from 
ods.ods_t_pro_dish_list_detail_test_demo limit 1"),
+            cfg = Some(Map(
+//                "doris.fenodes" -> "10.220.146.10:8030",
+                "doris.fenodes" -> "10.220.147.155:8030",

Review comment:
       hide the ip




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to