github-actions[bot] commented on code in PR #26689:
URL: https://github.com/apache/doris/pull/26689#discussion_r1390243461
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2127,35 +2205,28 @@
}
}
-void SegmentIterator::_build_index_result_column(uint16_t* sel_rowid_idx,
uint16_t select_size,
- vectorized::Block* block,
+void SegmentIterator::_build_index_result_column(const uint16_t* sel_rowid_idx,
Review Comment:
warning: method '_build_index_result_column' can be made const
[readability-make-member-function-const]
be/src/olap/rowset/segment_v2/segment_iterator.cpp:2210:
```diff
- const roaring::Roaring&
index_result) {
+ const roaring::Roaring&
index_result) const {
```
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -99,11 +99,12 @@ class SegmentIterator::BitmapRangeIterator {
explicit BitmapRangeIterator(const roaring::Roaring& bitmap) {
roaring_init_iterator(&bitmap.roaring, &_iter);
- _read_next_batch();
}
bool has_more_range() const { return !_eof; }
+ [[nodiscard]] uint32_t get_batch_size() const { return kBatchSize; }
Review Comment:
warning: method 'get_batch_size' can be made static
[readability-convert-member-functions-to-static]
```suggestion
[[nodiscard]] static uint32_t get_batch_size() { return kBatchSize; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
