github-actions[bot] commented on code in PR #26817:
URL: https://github.com/apache/doris/pull/26817#discussion_r1390313487
##########
be/src/pipeline/pipeline_x/pipeline_x_task.h:
##########
@@ -70,19 +70,32 @@ class PipelineXTask : public PipelineTask {
// must be call after all pipeline task is finish to release resource
Status close(Status exec_status) override;
- bool source_can_read() override {
- if (_dry_run) {
- return true;
- }
+ Dependency* read_blocked_by() {
Review Comment:
warning: method 'read_blocked_by' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Dependency* read_blocked_by() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
