caiconghui commented on code in PR #26611:
URL: https://github.com/apache/doris/pull/26611#discussion_r1390438301
##########
be/src/vec/sink/vtablet_finder.cpp:
##########
@@ -95,8 +95,22 @@ Status OlapTabletFinder::find_tablets(RuntimeState* state,
Block* block, int row
if (_find_tablet_mode == FindTabletMode::FIND_TABLET_EVERY_ROW) {
_vpartition->find_tablets(block, qualified_rows, partitions,
tablet_index);
} else {
+ // for random distribution
_vpartition->find_tablets(block, qualified_rows, partitions,
tablet_index,
&_partition_to_tablet_map);
+ if (_find_tablet_mode == FindTabletMode::FIND_TABLET_EVERY_BATCH) {
Review Comment:
the main contribution of random is to send the whole data batch to one
tablet, not save the find tablet time, which operation is light, and here
_partition_to_tablet_map size is small and not the bottleneck for distributing
data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
