github-actions[bot] commented on code in PR #26888:
URL: https://github.com/apache/doris/pull/26888#discussion_r1392064873
##########
be/src/exprs/runtime_filter.h:
##########
@@ -388,13 +392,21 @@ class IRuntimeFilter {
}
}
- int32_t wait_time_ms() {
- auto runtime_filter_wait_time_ms = _state == nullptr
- ?
_query_ctx->runtime_filter_wait_time_ms()
- :
_state->runtime_filter_wait_time_ms();
- return runtime_filter_wait_time_ms;
+ // For pipelineX & Producer
+ int32_t wait_time_ms() const {
+ int32_t res = 0;
+ if (wait_infinitly()) {
+ res = _state == nullptr ? _query_ctx->execution_timeout() :
_state->execution_timeout();
+ // Convert to ms
+ res *= 1000;
Review Comment:
warning: 1000 is a magic number; consider replacing it with a named constant
[readability-magic-numbers]
```cpp
res *= 1000;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
