yiguolei commented on code in PR #26191:
URL: https://github.com/apache/doris/pull/26191#discussion_r1392564155
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -447,13 +459,9 @@ class PredicateColumnType final : public
COWHelper<IColumn, PredicateColumnType<
// DateV1 and DateTimeV1 is special, its storage format is different
from compute format
// should convert here.
if constexpr (Type == TYPE_DATE || Type == TYPE_DATETIME) {
- if constexpr (std::is_same_v<T, uint32_t>) {
- insert_date_to_res_column(sel, sel_size, column);
- } else if constexpr (std::is_same_v<T, uint64_t>) {
- insert_datetime_to_res_column(sel, sel_size, column);
- } else {
- LOG(FATAL) << "not reachable";
- }
+ insert_datetime_to_res_column(sel, sel_size, column);
Review Comment:
If datev1 using the same type in predicate and compute layer, why do we need
use a specific method here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
