yangzhg commented on a change in pull request #5605:
URL: https://github.com/apache/incubator-doris/pull/5605#discussion_r608509041
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBEnvironment.java
##########
@@ -339,13 +339,12 @@ public void removeDatabase(String dbName) {
if (names != null) {
for (String name : names) {
- // We don't count epochDB
- if (name.equals("epochDB")) {
- continue;
+ try {
+ long db = Long.parseLong(name);
+ ret.add(db);
+ } catch (NumberFormatException e) {
Review comment:
Throws exception is too expensive and weird, may be
StringUtils.isNumeric() is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
