github-actions[bot] commented on code in PR #27699:
URL: https://github.com/apache/doris/pull/27699#discussion_r1407450622
##########
be/src/agent/cgroup_cpu_ctl.cpp:
##########
@@ -41,7 +41,7 @@ Status CgroupCpuCtl::init() {
return Status::OK();
}
-void CgroupCpuCtl::get_cgroup_cpu_info(uint64_t* cpu_shares, uint64_t*
cpu_hard_limit) {
+void CgroupCpuCtl::get_cgroup_cpu_info(uint64_t* cpu_shares, int*
cpu_hard_limit) {
Review Comment:
warning: method 'get_cgroup_cpu_info' can be made const
[readability-make-member-function-const]
```suggestion
void CgroupCpuCtl::get_cgroup_cpu_info(uint64_t* cpu_shares, int*
cpu_hard_limit) const {
```
be/src/agent/cgroup_cpu_ctl.h:50:
```diff
- void get_cgroup_cpu_info(uint64_t* cpu_shares, int* cpu_hard_limit);
+ void get_cgroup_cpu_info(uint64_t* cpu_shares, int* cpu_hard_limit)
const;
```
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -67,7 +67,7 @@ TaskGroupPtr TaskGroupManager::get_task_group_by_id(uint64_t
tg_id) {
return nullptr;
}
-bool TaskGroupManager::set_task_sche_for_query_ctx(uint64_t tg_id,
QueryContext* query_ctx_ptr) {
+bool TaskGroupManager::set_cg_task_sche_for_query_ctx(uint64_t tg_id,
QueryContext* query_ctx_ptr) {
Review Comment:
warning: method 'set_cg_task_sche_for_query_ctx' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:67:
```diff
- bool set_cg_task_sche_for_query_ctx(uint64_t tg_id, QueryContext*
query_ctx_ptr);
+ static bool set_cg_task_sche_for_query_ctx(uint64_t tg_id,
QueryContext* query_ctx_ptr);
```
##########
be/src/runtime/task_group/task_group_manager.cpp:
##########
@@ -83,8 +83,8 @@
return true;
}
-Status TaskGroupManager::upsert_task_scheduler(taskgroup::TaskGroupInfo*
tg_info,
- ExecEnv* exec_env) {
+Status TaskGroupManager::upsert_cg_task_scheduler(taskgroup::TaskGroupInfo*
tg_info,
Review Comment:
warning: method 'upsert_cg_task_scheduler' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/task_group/task_group_manager.h:53:
```diff
- Status upsert_cg_task_scheduler(taskgroup::TaskGroupInfo* tg_info,
ExecEnv* exec_env);
+ static Status upsert_cg_task_scheduler(taskgroup::TaskGroupInfo*
tg_info, ExecEnv* exec_env);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
