zhannngchen commented on code in PR #28062:
URL: https://github.com/apache/doris/pull/28062#discussion_r1417509658
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -343,6 +343,13 @@ Status
VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock& da
{
std::shared_lock rlock(tablet->get_header_lock());
specified_rowsets =
tablet->get_rowset_by_ids(&_mow_context->rowset_ids);
+ if (specified_rowsets.size() != _mow_context->rowset_ids.size()) {
Review Comment:
The method `_append_block_with_partial_content` of VerticalSegmentWriter
should be removed, it's useless for this class, you can submit another pull
request to do such cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
