github-actions[bot] commented on code in PR #28794:
URL: https://github.com/apache/doris/pull/28794#discussion_r1433701883
##########
be/src/olap/page_cache.cpp:
##########
@@ -66,7 +66,7 @@ bool StoragePageCache::lookup(const CacheKey& key,
PageCacheHandle* handle,
return true;
}
-void StoragePageCache::insert(const CacheKey& key, DataPage* data,
PageCacheHandle* handle,
+bool StoragePageCache::insert(const CacheKey& key, DataPage* data,
PageCacheHandle* handle,
Review Comment:
warning: method 'insert' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool StoragePageCache::insert(const CacheKey& key, DataPage* data,
PageCacheHandle* handle,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
