yiguolei commented on code in PR #28729:
URL: https://github.com/apache/doris/pull/28729#discussion_r1434688646
##########
be/src/olap/task/engine_batch_load_task.cpp:
##########
@@ -110,8 +110,10 @@ Status EngineBatchLoadTask::_init() {
// check disk capacity
if (_push_req.push_type == TPushType::LOAD_V2) {
- if
(tablet->data_dir()->reach_capacity_limit(_push_req.__isset.http_file_size)) {
- return Status::IOError("Disk does not have enough capacity");
+ if
(tablet->data_dir()->reach_capacity_limit(_push_req.http_file_size)) {
+ return Status::Error<EXCEEDED_LIMIT>(
+ "reach the capacity limit of path {}, file_size={}",
tablet->data_dir()->path(),
Review Comment:
not modify
##########
be/src/olap/types.h:
##########
@@ -1444,7 +1444,7 @@ struct FieldTypeTraits<FieldType::OLAP_FIELD_TYPE_STRING>
const int scale) {
size_t value_len = scan_key.length();
if (value_len > config::string_type_length_soft_limit_bytes) {
- return Status::Error<ErrorCode::INVALID_ARGUMENT>(
+ return Status::Error<ErrorCode::EXCEEDED_LIMIT>(
Review Comment:
not modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
