amorynan commented on code in PR #28556:
URL: https://github.com/apache/doris/pull/28556#discussion_r1438094534
##########
be/src/vec/runtime/ipv6_value.h:
##########
@@ -65,6 +65,11 @@ class IPv6Value {
return {buf, len};
}
+ static bool is_valid_string(const std::string& ipv6_str) {
+ vectorized::IPv6 value;
+ return from_string(value, ipv6_str);
Review Comment:
does from_string costs more time than parseIpV4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
