github-actions[bot] commented on code in PR #29669:
URL: https://github.com/apache/doris/pull/29669#discussion_r1444252351
##########
be/src/olap/rowset/rowset.h:
##########
@@ -304,6 +304,14 @@ class Rowset : public std::enable_shared_from_this<Rowset>
{
[[nodiscard]] virtual Status add_to_binlog() { return Status::OK(); }
+ // is skip index compaction this time
+ bool is_skip_index_compaction(int32_t column_id) const {
Review Comment:
warning: function 'is_skip_index_compaction' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
ime[[nodiscard]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
