github-actions[bot] commented on code in PR #29723:
URL: https://github.com/apache/doris/pull/29723#discussion_r1445764037
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.h:
##########
@@ -142,11 +143,29 @@ class RowGroupReader {
PositionDeleteContext(const PositionDeleteContext& filter) = default;
};
+ class EqualityDeleteNode {
+ public:
+ size_t _row_pos;
+ std::map<size_t, int> _hit_map;
+ int _hit_max;
Review Comment:
warning: use default member initializer for '_hit_max'
[modernize-use-default-member-init]
```suggestion
int _hit_max{0};
```
be/src/vec/exec/format/parquet/vparquet_group_reader.h:152:
```diff
- EqualityDeleteNode(size_t pos) : _row_pos(pos), _hit_max(0) {}
+ EqualityDeleteNode(size_t pos) : _row_pos(pos), {}
```
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.h:
##########
@@ -142,11 +143,29 @@
PositionDeleteContext(const PositionDeleteContext& filter) = default;
};
+ class EqualityDeleteNode {
+ public:
+ size_t _row_pos;
+ std::map<size_t, int> _hit_map;
+ int _hit_max;
+
+ public:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/parquet/vparquet_group_reader.h:146:** previously
declared here
```cpp
public:
^
```
</details>
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:
##########
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-#include "vparquet_group_reader.h"
-
#include <gen_cpp/Exprs_types.h>
Review Comment:
warning: 'gen_cpp/Exprs_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Exprs_types.h>
^
```
##########
be/src/vec/exec/scan/vfile_scanner.cpp:
##########
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-#include "vec/exec/scan/vfile_scanner.h"
-
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-#include "vparquet_reader.h"
-
#include <gen_cpp/Metrics_types.h>
Review Comment:
warning: 'gen_cpp/Metrics_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Metrics_types.h>
^
```
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.h:
##########
@@ -179,6 +198,7 @@
Block* block, size_t rows,
const std::unordered_map<std::string, VExprContextSPtr>&
missing_columns);
Status _build_pos_delete_filter(size_t read_rows);
+ Status _build_equality_delete_filter(Block* block, const size_t read_rows);
Review Comment:
warning: parameter 'read_rows' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
Status _build_equality_delete_filter(Block* block, size_t read_rows);
```
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.h:
##########
@@ -142,11 +143,29 @@
PositionDeleteContext(const PositionDeleteContext& filter) = default;
};
+ class EqualityDeleteNode {
+ public:
+ size_t _row_pos;
+ std::map<size_t, int> _hit_map;
+ int _hit_max;
+
+ public:
+ EqualityDeleteNode(size_t pos) : _row_pos(pos), _hit_max(0) {}
+ int add(size_t des_pos) {
+ if (_hit_map.find(des_pos) == _hit_map.end()) _hit_map[des_pos] =
0;
+ _hit_map[des_pos] += 1;
+ if (_hit_max < _hit_map[des_pos]) _hit_max = _hit_map[des_pos];
+ return _hit_map[des_pos];
+ }
+ int max() { return _hit_max; }
Review Comment:
warning: method 'max' can be made const
[readability-make-member-function-const]
```suggestion
int max() const { return _hit_max; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
