github-actions[bot] commented on code in PR #29791:
URL: https://github.com/apache/doris/pull/29791#discussion_r1447085238
##########
be/src/vec/sink/load_stream_stub.cpp:
##########
@@ -299,6 +306,36 @@ Status LoadStreamStub::wait_for_schema(int64_t
partition_id, int64_t index_id, i
return Status::OK();
}
+Status LoadStreamStub::close_wait(int64_t timeout_ms) {
Review Comment:
warning: method 'close_wait' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/load_stream_stub.h:157:
```diff
- Status close_wait(int64_t timeout_ms = 0);
+ static Status close_wait(int64_t timeout_ms = 0);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
