freemandealer commented on code in PR #29839:
URL: https://github.com/apache/doris/pull/29839#discussion_r1448347093
##########
regression-test/suites/fault_injection_p0/test_load_stream_fault_injection.groovy:
##########
@@ -161,14 +161,10 @@ suite("load_stream_fault_injection", "nonConcurrent") {
load_with_injection("LoadStream._dispatch.unknown_srcid", "")
// LoadStream meets StreamRPC idle timeout
- get_be_param("load_stream_idle_timeout_ms")
- set_be_param("load_stream_idle_timeout_ms", 500)
try {
load_with_injection("LoadStreamStub._send_with_retry.delay_before_send", "")
Review Comment:
enable both delay_before_send and short_idle_timeout before actual load to
trigger on_idle_timeout?
##########
be/src/service/internal_service.cpp:
##########
@@ -391,7 +391,10 @@ void
PInternalServiceImpl::open_load_stream(google::protobuf::RpcController* con
}
stream_options.handler = load_stream.get();
- stream_options.idle_timeout_ms = config::load_stream_idle_timeout_ms;
+ stream_options.idle_timeout_ms = request->idle_timeout_ms();
+ DBUG_EXECUTE_IF("LoadStreamStub._send_with_retry.delay_before_send", {
Review Comment:
Maybe use another debug point name? this one is already taken by
LoadStreamStub::_send_with_retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
