dutyu commented on code in PR #29692:
URL: https://github.com/apache/doris/pull/29692#discussion_r1449972569
##########
fe/fe-core/src/main/java/org/apache/doris/qe/GlobalVariable.java:
##########
@@ -104,7 +110,22 @@ public final class GlobalVariable {
@VariableMgr.VarAttr(name = SHOW_FULL_DBNAME_IN_INFO_SCHEMA_DB, flag =
VariableMgr.GLOBAL)
public static boolean showFullDbNameInInfoSchemaDb = false;
- // Don't allow to create instance.
+ @VariableMgr.VarAttr(name = SQL_CONVERTER_SERVICE, flag =
VariableMgr.GLOBAL)
+ public static String sqlConverterService = "";
Review Comment:
Maybe `sqlConverterServiceUrl` fits the meaning better? just my personal
preference
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java:
##########
@@ -439,8 +433,10 @@ private Object executeWithClusterToken(HttpServletRequest
request, String db,
return redirectView;
} catch (Exception e) {
- LOG.warn("Failed to execute stream load with cluster token, {}",
e);
+ LOG.warn("Failed to execute stream load with cluster token, {}",
e.getMessage(), e);
Review Comment:
Maybe `LOG.warn("Failed to execute stream load with cluster token:", e);` is
enough?
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/InternalSchemaInitializer.java:
##########
@@ -83,6 +113,7 @@ public void run() {
Database database = op.get();
modifyTblReplicaCount(database, StatisticConstants.STATISTIC_TBL_NAME);
modifyTblReplicaCount(database, StatisticConstants.HISTOGRAM_TBL_NAME);
+ modifyTblReplicaCount(database, AuditLoaderPlugin.AUDIT_LOG_TABLE);
Review Comment:
Should we move `StatisticConstants.STATISTIC_INTERNAL_TABLE_REPLICA_NUM` to
this file and rename it to `INTERNAL_TABLE_REPLICA_NUM`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
