amorynan commented on code in PR #29812:
URL: https://github.com/apache/doris/pull/29812#discussion_r1450025323


##########
be/src/vec/functions/function_ip.h:
##########
@@ -832,4 +835,128 @@ class FunctionIsIPAddressInRange : public IFunction {
     }
 };
 
+class FunctionIPv6CIDRToRange : public IFunction {
+public:
+    static constexpr auto name = "ipv6_cidr_to_range";
+    static FunctionPtr create() { return 
std::make_shared<FunctionIPv6CIDRToRange>(); }
+
+    String get_name() const override { return name; }
+
+    size_t get_number_of_arguments() const override { return 2; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const 
override {
+        const auto& ipv6_type = arguments[0];
+        if (!is_string(remove_nullable(ipv6_type)) && 
!is_ipv6(remove_nullable(ipv6_type))) {
+            throw Exception(
+                    ErrorCode::INVALID_ARGUMENT,
+                    "Illegal type {} of first argument of function {}, 
expected String or IPv6",
+                    ipv6_type->get_name(), get_name());
+        }
+        const auto& cidr_type = arguments[1];
+        if (!is_integer(remove_nullable(cidr_type))) {
+            throw Exception(ErrorCode::INVALID_ARGUMENT,
+                            "Illegal type {} of second argument of function 
{}, expected Integer",
+                            cidr_type->get_name(), get_name());
+        }
+        DataTypePtr element = std::make_shared<DataTypeIPv6>();
+        return make_nullable(std::make_shared<DataTypeStruct>(DataTypes 
{element, element},
+                                                              Strings {"min", 
"max"}));
+    }
+
+    bool use_default_implementation_for_nulls() const override { return true; }
+
+    Status execute_impl(FunctionContext* context, Block& block, const 
ColumnNumbers& arguments,
+                        size_t result, size_t input_rows_count) const override 
{
+        ColumnPtr& addr_column = block.get_by_position(arguments[0]).column;
+        ColumnPtr& cidr_column = block.get_by_position(arguments[1]).column;
+        const IColumn* cidr_col = nullptr;
+        const NullMap* cidr_nullmap = nullptr;
+        ColumnPtr col_res = nullptr;
+
+        if (cidr_column->is_nullable()) {
+            const auto* cidr_column_nullable =
+                    assert_cast<const ColumnNullable*>(cidr_column.get());
+            cidr_col = &cidr_column_nullable->get_nested_column();
+            cidr_nullmap = &cidr_column_nullable->get_null_map_data();
+        } else {
+            cidr_col = cidr_column.get();
+        }
+
+        if (addr_column->is_nullable()) {
+            const auto* addr_column_nullable =
+                    assert_cast<const ColumnNullable*>(addr_column.get());
+            const NullMap* addr_nullmap = 
&addr_column_nullable->get_null_map_data();
+            if (const auto* ipv6_addr_column = 
check_and_get_column<ColumnIPv6>(
+                        addr_column_nullable->get_nested_column())) {
+                col_res = execute_impl<ColumnIPv6>(*ipv6_addr_column, 
addr_nullmap, *cidr_col,
+                                                   cidr_nullmap, 
input_rows_count);
+            } else if (const auto* str_addr_column = 
check_and_get_column<ColumnString>(
+                               addr_column_nullable->get_nested_column())) {
+                col_res = execute_impl<ColumnString>(*str_addr_column, 
addr_nullmap, *cidr_col,
+                                                     cidr_nullmap, 
input_rows_count);
+            } else {
+                return Status::RuntimeError("Illegal column {} of argument of 
function {}",
+                                            addr_column->get_name(), 
get_name());
+            }
+        } else {
+            if (const auto* ipv6_addr_column =
+                        check_and_get_column<ColumnIPv6>(addr_column.get())) {
+                col_res = execute_impl<ColumnIPv6>(*ipv6_addr_column, nullptr, 
*cidr_col, nullptr,
+                                                   input_rows_count);
+            } else if (const auto* str_addr_column =
+                               
check_and_get_column<ColumnString>(addr_column.get())) {
+                col_res = execute_impl<ColumnString>(*str_addr_column, 
nullptr, *cidr_col, nullptr,
+                                                     input_rows_count);
+            } else {
+                return Status::RuntimeError("Illegal column {} of argument of 
function {}",
+                                            addr_column->get_name(), 
get_name());
+            }
+        }
+
+        block.replace_by_position(result, std::move(col_res));
+        return Status::OK();
+    }
+
+    template <typename FromColumn>
+    static ColumnPtr execute_impl(const FromColumn& from_column, const 
NullMap* from_nullmap,
+                                  const IColumn& cidr_column, const NullMap* 
cidr_nullmap,
+                                  size_t input_rows_count) {
+        auto col_res_lower_range = ColumnIPv6::create(input_rows_count, 0);
+        auto col_res_upper_range = ColumnIPv6::create(input_rows_count, 0);
+        auto col_res_null_map = ColumnUInt8::create(input_rows_count, 0);
+        auto& vec_res_lower_range = col_res_lower_range->get_data();
+        auto& vec_res_upper_range = col_res_upper_range->get_data();
+        auto& vec_res_null_map = col_res_null_map->get_data();
+
+        static constexpr Int64 max_cidr_mask = IPV6_BINARY_LENGTH * 8;
+
+        for (size_t i = 0; i < input_rows_count; ++i) {
+            if ((from_nullmap && (*from_nullmap)[i]) || (cidr_nullmap && 
(*cidr_nullmap)[i])) {
+                vec_res_null_map[i] = 1;
+                continue;
+            }
+            Int64 cidr = cidr_column.get_int(i);

Review Comment:
   make function param cidr column is column vector



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to