dataroaring commented on code in PR #29818:
URL: https://github.com/apache/doris/pull/29818#discussion_r1450089374
##########
be/src/olap/storage_engine.cpp:
##########
@@ -448,45 +450,89 @@ Status StorageEngine::set_cluster_id(int32_t cluster_id) {
return Status::OK();
}
+StorageEngine::Disk_remaining_level get_available_level(double
disk_usage_percent) {
+ assert(disk_usage_percent <= 1);
+ if (disk_usage_percent < 0.7) {
+ return StorageEngine::Disk_remaining_level::LOW;
+ } else if (disk_usage_percent < 0.85) {
+ return StorageEngine::Disk_remaining_level::MID;
+ }
+ return StorageEngine::Disk_remaining_level::HIGH;
+}
+
std::vector<DataDir*> StorageEngine::get_stores_for_create_tablet(
- TStorageMedium::type storage_medium) {
+ int64 partition_id, TStorageMedium::type storage_medium) {
+ struct DirInfo {
Review Comment:
A too long function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
