This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 809e8cb5475 [cleanup](insert-into) clean up some insert into log
(#30063)
809e8cb5475 is described below
commit 809e8cb5475c58174cbbfeeaa7348e6687e03f55
Author: HHoflittlefish777 <[email protected]>
AuthorDate: Wed Jan 17 19:59:14 2024 +0800
[cleanup](insert-into) clean up some insert into log (#30063)
---
be/src/pipeline/exec/union_source_operator.cpp | 6 ------
be/src/runtime/fragment_mgr.cpp | 5 -----
be/src/vec/exec/vunion_node.cpp | 6 ------
.../src/main/java/org/apache/doris/qe/Coordinator.java | 14 +++-----------
regression-test/pipeline/p0/conf/be.conf | 2 +-
5 files changed, 4 insertions(+), 29 deletions(-)
diff --git a/be/src/pipeline/exec/union_source_operator.cpp
b/be/src/pipeline/exec/union_source_operator.cpp
index 31806d7242c..e8ef1ba7207 100644
--- a/be/src/pipeline/exec/union_source_operator.cpp
+++ b/be/src/pipeline/exec/union_source_operator.cpp
@@ -223,9 +223,6 @@ Status UnionSourceOperatorX::get_next_const(RuntimeState*
state, vectorized::Blo
&result_list[i]));
}
tmp_block.erase_not_in(result_list);
- VLOG_ROW << "query id: " << print_id(state->query_id())
- << ", instance id: " <<
print_id(state->fragment_instance_id())
- << ", tmp_block rows: " << tmp_block.rows();
if (tmp_block.rows() > 0) {
RETURN_IF_ERROR(mblock.merge(tmp_block));
tmp_block.clear();
@@ -235,9 +232,6 @@ Status UnionSourceOperatorX::get_next_const(RuntimeState*
state, vectorized::Blo
// some insert query like "insert into string_test select 1, repeat('a',
1024 * 1024);"
// the const expr will be in output expr cause the union node return a
empty block. so here we
// need add one row to make sure the union node exec const expr return at
least one row
- VLOG_ROW << "query id: " << print_id(state->query_id())
- << ", instance id: " << print_id(state->fragment_instance_id())
- << ", tmp_block rows: " << block->rows();
if (block->rows() == 0) {
block->insert({vectorized::ColumnUInt8::create(1),
std::make_shared<vectorized::DataTypeUInt8>(), ""});
diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index 7d3dba81020..0fbaacb4fa2 100644
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -322,11 +322,6 @@ void FragmentMgr::coordinator_callback(const
ReportStatusRequest& req) {
params.load_counters.emplace(s_dpp_normal_all,
std::to_string(num_rows_load_success));
params.load_counters.emplace(s_dpp_abnormal_all,
std::to_string(num_rows_load_filtered));
params.load_counters.emplace(s_unselected_rows,
std::to_string(num_rows_load_unselected));
- LOG(INFO) << "execute coordinator callback, query id: " <<
print_id(req.query_id)
- << ", instance id: " << print_id(req.fragment_instance_id)
- << ", num_rows_load_success: " << num_rows_load_success
- << ", num_rows_load_filtered: " << num_rows_load_filtered
- << ", num_rows_load_unselected: " <<
num_rows_load_unselected;
if (!req.runtime_state->get_error_log_file_path().empty()) {
params.__set_tracking_url(
diff --git a/be/src/vec/exec/vunion_node.cpp b/be/src/vec/exec/vunion_node.cpp
index 77f9c0a40f2..8ee258ca056 100644
--- a/be/src/vec/exec/vunion_node.cpp
+++ b/be/src/vec/exec/vunion_node.cpp
@@ -229,18 +229,12 @@ Status VUnionNode::get_next_const(RuntimeState* state,
Block* block) {
&result_list[i]));
}
tmp_block.erase_not_in(result_list);
- VLOG_ROW << "query id: " << print_id(state->query_id())
- << ", instance id: " <<
print_id(state->fragment_instance_id())
- << ", tmp_block rows: " << tmp_block.rows();
if (tmp_block.rows() > 0) {
RETURN_IF_ERROR(mblock.merge(tmp_block));
tmp_block.clear();
}
}
block->set_columns(std::move(mblock.mutable_columns()));
- VLOG_ROW << "query id: " << print_id(state->query_id())
- << ", instance id: " << print_id(state->fragment_instance_id())
- << ", block rows: " << block->rows();
// some insert query like "insert into string_test select 1, repeat('a',
1024 * 1024);"
// the const expr will be in output expr cause the union node return a
empty block. so here we
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
index 165583b9e68..2f58e560740 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
@@ -688,12 +688,6 @@ public class Coordinator implements CoordInterface {
} else {
executionProfile.markInstances(instanceIds);
}
- StringBuilder ids = new StringBuilder();
- for (TUniqueId instanceId : instanceIds) {
- ids.append(DebugUtil.printId(instanceId));
- ids.append(", ");
- }
- LOG.info("mark instances: {}", ids.toString());
if (enablePipelineEngine) {
sendPipelineCtx();
@@ -2494,7 +2488,7 @@ public class Coordinator implements CoordInterface {
Preconditions.checkArgument(params.isSetDetailedReport());
if (ctx.done) {
- LOG.info("Query {} fragment {} is marked done",
+ LOG.debug("Query {} fragment {} is marked done",
DebugUtil.printId(queryId), ctx.profileFragmentId);
executionProfile.markOneFragmentDone(ctx.profileFragmentId);
}
@@ -2552,11 +2546,11 @@ public class Coordinator implements CoordInterface {
if (params.isSetErrorTabletInfos()) {
updateErrorTabletInfos(params.getErrorTabletInfos());
}
- LOG.info("Query {} instance {} is marked done",
+ LOG.debug("Query {} instance {} is marked done",
DebugUtil.printId(queryId),
DebugUtil.printId(params.getFragmentInstanceId()));
executionProfile.markOneInstanceDone(params.getFragmentInstanceId());
} else {
- LOG.info("Query {} instance {} is not marked done",
+ LOG.debug("Query {} instance {} is not marked done",
DebugUtil.printId(queryId),
DebugUtil.printId(params.getFragmentInstanceId()));
}
} else {
@@ -2623,8 +2617,6 @@ public class Coordinator implements CoordInterface {
if (params.isSetErrorTabletInfos()) {
updateErrorTabletInfos(params.getErrorTabletInfos());
}
- LOG.info("Query {} instance {} is marked done",
- DebugUtil.printId(queryId),
DebugUtil.printId(params.getFragmentInstanceId()));
executionProfile.markOneInstanceDone(params.getFragmentInstanceId());
}
}
diff --git a/regression-test/pipeline/p0/conf/be.conf
b/regression-test/pipeline/p0/conf/be.conf
index c2c09ec89dd..d562e864a84 100644
--- a/regression-test/pipeline/p0/conf/be.conf
+++ b/regression-test/pipeline/p0/conf/be.conf
@@ -59,7 +59,7 @@ chunk_reserved_bytes_limit = 134217728
# sys_log_dir = ${DORIS_HOME}/log
# sys_log_roll_mode = SIZE-MB-1024
# sys_log_roll_num = 10
-sys_log_verbose_modules = fragment_mgr,vunion_node,union_source_operator
+# sys_log_verbose_modules = *
log_buffer_level = -1
enable_stream_load_record = true
# palo_cgroups
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
