morningman commented on a change in pull request #6321:
URL: https://github.com/apache/incubator-doris/pull/6321#discussion_r682716294
##########
File path: be/src/agent/task_worker_pool.cpp
##########
@@ -1185,9 +1185,15 @@ void
TaskWorkerPool::_report_tablet_worker_thread_callback() {
_is_doing_work = true;
request.tablets.clear();
+ uint64_t report_version = _s_report_version;
Review comment:
using `report_version` in `request`
##########
File path: be/src/agent/task_worker_pool.cpp
##########
@@ -1185,9 +1185,15 @@ void
TaskWorkerPool::_report_tablet_worker_thread_callback() {
_is_doing_work = true;
request.tablets.clear();
+ uint64_t report_version = _s_report_version;
OLAPStatus build_all_report_tablets_info_status =
StorageEngine::instance()->tablet_manager()->build_all_report_tablets_info(
&request.tablets);
+ if (report_version < _s_report_version) {
Review comment:
Add a TODO here to notice that this can only reduce the possibility or
report error, but can't avoid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
