github-actions[bot] commented on code in PR #26673:
URL: https://github.com/apache/doris/pull/26673#discussion_r1460599462
##########
be/src/pipeline/exec/operator.h:
##########
@@ -19,20 +19,16 @@
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/vec/exprs/vexpr_context.h:
##########
@@ -20,6 +20,7 @@
#include <glog/logging.h>
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include <glog/logging.h>
^
```
##########
be/src/exec/exec_node.h:
##########
@@ -21,10 +21,10 @@
#pragma once
#include <gen_cpp/PlanNodes_types.h>
Review Comment:
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/PlanNodes_types.h>
^
```
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -212,8 +214,7 @@
return pipeline;
}
-Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams&
request,
- const size_t idx) {
+Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams&
request, size_t idx) {
Review Comment:
warning: function 'prepare' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_fragment_context.cpp:216:** 148 lines including
whitespace and comments (threshold 80)
```cpp
^
```
</details>
##########
be/src/vec/runtime/vdata_stream_recvr.h:
##########
@@ -20,11 +20,11 @@
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -212,8 +214,7 @@ PipelinePtr
PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {
return pipeline;
}
-Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams&
request,
- const size_t idx) {
+Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams&
request, size_t idx) {
Review Comment:
warning: function 'prepare' has cognitive complexity of 52 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_fragment_context.cpp:217:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
) {
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:236:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
v);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:249:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:252:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:255:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:258:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:262:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:266:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:268:** +1, nesting level
increased to 1
```cpp
bl;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:270:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
l);
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:270:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
l);
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:276:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
ext
^
```
**be/src/common/exception.h:105:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
do {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:276:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
ext
^
```
**be/src/common/exception.h:111:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
if (UNLIKELY(!_status_.ok())) {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:276:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
ext
^
```
**be/src/common/exception.h:115:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
} catch (const doris::Exception& e) {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:276:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
ext
^
```
**be/src/common/exception.h:116:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
if (e.code() == doris::ErrorCode::MEM_ALLOC_FAILED) {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:291:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
ree
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:291:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
ree
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:335:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:337:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
tor
^
```
**be/src/common/exception.h:105:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
do {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:337:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
tor
^
```
**be/src/common/exception.h:111:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
if (UNLIKELY(!_status_.ok())) {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:337:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
tor
^
```
**be/src/common/exception.h:115:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
} catch (const doris::Exception& e) {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:337:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
tor
^
```
**be/src/common/exception.h:116:** expanded from macro
'RETURN_IF_ERROR_OR_CATCH_EXCEPTION'
```cpp
if (e.code() == doris::ErrorCode::MEM_ALLOC_FAILED) {
\
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:345:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
();
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:345:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
();
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:346:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
));
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:348:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
ere
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:348:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
ere
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:351:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/common/status.h:528:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:351:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
}
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:352:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
));
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:355:** +1, nesting level
increased to 1
```cpp
r);
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
