github-actions[bot] commented on code in PR #30245:
URL: https://github.com/apache/doris/pull/30245#discussion_r1462082966
##########
be/src/olap/base_tablet.cpp:
##########
@@ -119,4 +119,25 @@ bool
BaseTablet::_reconstruct_version_tracker_if_necessary() {
return false;
}
+// should use this method to get a copy of current tablet meta
+// there are some rowset meta in local meta store and in in-memory tablet meta
+// but not in tablet meta in local meta store
+void BaseTablet::generate_tablet_meta_copy(TabletMeta& new_tablet_meta) const {
+ TabletMetaPB tablet_meta_pb;
+ {
+ std::shared_lock rdlock(_meta_lock);
+ _tablet_meta->to_meta_pb(&tablet_meta_pb);
+ }
+ generate_tablet_meta_copy_unlocked(new_tablet_meta);
+}
+
+// this is a unlocked version of generate_tablet_meta_copy()
+// some method already hold the _meta_lock before calling this,
+// such as EngineCloneTask::_finish_clone -> tablet->revise_tablet_meta
+void BaseTablet::generate_tablet_meta_copy_unlocked(TabletMeta&
new_tablet_meta) const {
Review Comment:
warning: method 'generate_tablet_meta_copy_unlocked' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/base_tablet.h:91:
```diff
- void generate_tablet_meta_copy_unlocked(TabletMeta& new_tablet_meta)
const;
+ static void generate_tablet_meta_copy_unlocked(TabletMeta&
new_tablet_meta) ;
```
```suggestion
void BaseTablet::generate_tablet_meta_copy_unlocked(TabletMeta&
new_tablet_meta) {
```
##########
be/src/agent/agent_server.cpp:
##########
@@ -316,8 +316,9 @@ void AgentServer::make_snapshot(TAgentResult&
t_agent_result,
t_agent_result.__set_snapshot_version(snapshot_request.preferred_snapshot_version);
}
-void AgentServer::release_snapshot(TAgentResult& t_agent_result, const
std::string& snapshot_path) {
- Status status =
SnapshotManager::instance()->release_snapshot(snapshot_path);
+void AgentServer::release_snapshot(StorageEngine& engine, TAgentResult&
t_agent_result,
Review Comment:
warning: method 'release_snapshot' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void AgentServer::release_snapshot(StorageEngine& engine,
TAgentResult& t_agent_result,
```
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1169,22 +1199,22 @@
_report_listeners.push_back(listener);
}
-void StorageEngine::deregister_report_listener(ReportWorker* listener) {
+void BaseStorageEngine::deregister_report_listener(ReportWorker* listener) {
std::lock_guard<std::mutex> l(_report_mtx);
if (auto it = std::find(_report_listeners.begin(),
_report_listeners.end(), listener);
it != _report_listeners.end()) {
_report_listeners.erase(it);
}
}
-void StorageEngine::notify_listeners() {
+void BaseStorageEngine::notify_listeners() {
std::lock_guard<std::mutex> l(_report_mtx);
for (auto& listener : _report_listeners) {
listener->notify();
}
}
-bool StorageEngine::notify_listener(std::string_view name) {
+bool BaseStorageEngine::notify_listener(std::string_view name) {
Review Comment:
warning: method 'notify_listener' can be made static
[readability-convert-member-functions-to-static]
```suggestion
ner->notify();static
```
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -339,7 +340,7 @@ void
SegmentWriter::_serialize_block_to_row_column(vectorized::Block& block) {
// 3. set columns to data convertor and then write all columns
Status SegmentWriter::append_block_with_partial_content(const
vectorized::Block* block,
Review Comment:
warning: function 'append_block_with_partial_content' has cognitive
complexity of 54 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status SegmentWriter::append_block_with_partial_content(const
vectorized::Block* block,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/segment_writer.cpp:342:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (config::is_cloud_mode()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:348:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (block->columns() <= _tablet_schema->num_key_columns() ||
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:401:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (const vectorized::ColumnWithTypeAndName* delete_sign_column =
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:406:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (delete_sign_col.size() >= row_pos + num_rows) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:415:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode &&
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:434:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (size_t block_pos = row_pos; block_pos < row_pos + num_rows;
block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:445:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:451:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (!_tablet_schema->has_sequence_col() || have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:452:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:452:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:457:** +1
```cpp
(delete_sign_column_data != nullptr &&
delete_sign_column_data[block_pos] != 0);
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:464:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_NOT_FOUND>()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:465:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:472:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:473:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
if
(!_opts.rowset_ctx->partial_update_info->can_insert_new_rows_in_partial_update)
{
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:493:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok() && !st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:501:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (have_delete_sign) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:504:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:511:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:517:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:524:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:531:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:531:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:535:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->store_row_column()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:559:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->has_sequence_col() && !have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:566:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (_num_rows_written != row_pos ||
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:573:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t block_pos = row_pos; block_pos < row_pos + num_rows;
block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:576:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:576:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
##########
be/src/olap/task/engine_publish_version_task.h:
##########
@@ -15,11 +15,9 @@
// specific language governing permissions and limitations
// under the License.
-#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_PUBLISH_VERSION_TASK_H
-#define DORIS_BE_SRC_OLAP_TASK_ENGINE_PUBLISH_VERSION_TASK_H
+#pragma once
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/service/http_service.cpp:
##########
@@ -294,6 +223,99 @@
new ClearDebugPointsAction(_env, TPrivilegeHier::GLOBAL,
TPrivilegeType::ADMIN));
_ev_http_server->register_handler(HttpMethod::POST,
"/api/debug_point/clear",
clear_debug_points_action);
+}
+
+void HttpService::register_local_handler(StorageEngine& engine) {
Review Comment:
warning: function 'register_local_handler' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void HttpService::register_local_handler(StorageEngine& engine) {
^
```
<details>
<summary>Additional context</summary>
**be/src/service/http_service.cpp:227:** 99 lines including whitespace and
comments (threshold 80)
```cpp
void HttpService::register_local_handler(StorageEngine& engine) {
^
```
</details>
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -285,7 +286,7 @@ void
VerticalSegmentWriter::_serialize_block_to_row_column(vectorized::Block& bl
// 2.3 fill block
// 3. set columns to data convertor and then write all columns
Status VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock&
data) {
Review Comment:
warning: function '_append_block_with_partial_content' has cognitive
complexity of 53 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status
VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock& data) {
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:288:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::is_cloud_mode()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:335:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (const vectorized::ColumnWithTypeAndName* delete_sign_column =
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:340:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (delete_sign_col.size() >= data.row_pos + data.num_rows) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:349:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode &&
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:368:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
for (size_t block_pos = data.row_pos; block_pos < data.row_pos +
data.num_rows; block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:379:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:385:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (!_tablet_schema->has_sequence_col() || have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:386:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:386:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:391:** +1
```cpp
(delete_sign_column_data != nullptr &&
delete_sign_column_data[block_pos] != 0);
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:398:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_NOT_FOUND>()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:399:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:405:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:406:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if
(!_opts.rowset_ctx->partial_update_info->can_insert_new_rows_in_partial_update)
{
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:426:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok() && !st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:434:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (have_delete_sign) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:437:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:444:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:450:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:457:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:464:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:464:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:467:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->store_row_column()) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:491:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->has_sequence_col() && !have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:498:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_num_rows_written != data.row_pos ||
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:505:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t block_pos = data.row_pos; block_pos < data.row_pos +
data.num_rows;
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:509:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:530:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:509:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
##########
be/src/olap/rowset/rowset_factory.cpp:
##########
@@ -45,17 +47,18 @@ Status RowsetFactory::create_rowset(const TabletSchemaSPtr&
schema, const std::s
return Status::Error<ROWSET_TYPE_NOT_FOUND>("invalid rowset_type"); //
should never happen
}
-Status RowsetFactory::create_rowset_writer(const RowsetWriterContext& context,
bool is_vertical,
+Status RowsetFactory::create_rowset_writer(StorageEngine& engine,
Review Comment:
warning: method 'create_rowset_writer' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RowsetFactory::create_rowset_writer(StorageEngine& engine,
```
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1160,7 +1190,7 @@ Status StorageEngine::load_header(const string&
shard_path, const TCloneReq& req
return res;
}
-void StorageEngine::register_report_listener(ReportWorker* listener) {
+void BaseStorageEngine::register_report_listener(ReportWorker* listener) {
Review Comment:
warning: method 'register_report_listener' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.h:109:
```diff
- void register_report_listener(ReportWorker* listener);
+ static void register_report_listener(ReportWorker* listener);
```
##########
be/src/olap/task/engine_clone_task.h:
##########
@@ -15,19 +15,17 @@
// specific language governing permissions and limitations
// under the License.
-#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_CLONE_TASK_H
-#define DORIS_BE_SRC_OLAP_TASK_ENGINE_CLONE_TASK_H
+#pragma once
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1169,22 +1199,22 @@
_report_listeners.push_back(listener);
}
-void StorageEngine::deregister_report_listener(ReportWorker* listener) {
+void BaseStorageEngine::deregister_report_listener(ReportWorker* listener) {
Review Comment:
warning: method 'deregister_report_listener' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/storage_engine.h:110:
```diff
- void deregister_report_listener(ReportWorker* listener);
+ static void deregister_report_listener(ReportWorker* listener);
```
##########
be/src/olap/task/engine_checksum_task.h:
##########
@@ -19,7 +19,6 @@
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_CHECKSUM_TASK_H
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/service/http_service.cpp:
##########
@@ -270,15 +190,24 @@ Status HttpService::start() {
_ev_http_server->register_handler(HttpMethod::GET,
"/api/reset_rpc_channel/{endpoints}",
reset_rpc_channel_action);
- CheckTabletSegmentAction* check_tablet_segment_action = _pool.add(
- new CheckTabletSegmentAction(_env, TPrivilegeHier::GLOBAL,
TPrivilegeType::ADMIN));
- _ev_http_server->register_handler(HttpMethod::POST,
"/api/check_tablet_segment_lost",
- check_tablet_segment_action);
+ register_debug_point_handler();
- PadRowsetAction* pad_rowset_action =
- _pool.add(new PadRowsetAction(_env, TPrivilegeHier::GLOBAL,
TPrivilegeType::ADMIN));
- _ev_http_server->register_handler(HttpMethod::POST, "/api/pad_rowset",
pad_rowset_action);
+ ReportAction* report_task_action = _pool.add(
+ new ReportAction(_env, TPrivilegeHier::GLOBAL,
TPrivilegeType::ADMIN, "REPORT_TASK"));
+ _ev_http_server->register_handler(HttpMethod::GET, "/api/report/task",
report_task_action);
+
+ auto& engine = _env->storage_engine();
+ if (config::is_cloud_mode()) {
+ register_cloud_handler(engine.to_cloud());
+ } else {
+ register_local_handler(engine.to_local());
+ }
+
+ _ev_http_server->start();
+ return Status::OK();
+}
+void HttpService::register_debug_point_handler() {
Review Comment:
warning: method 'register_debug_point_handler' can be made static
[readability-convert-member-functions-to-static]
be/src/service/http_service.h:47:
```diff
- void register_debug_point_handler();
+ static void register_debug_point_handler();
```
##########
be/src/runtime/snapshot_loader.h:
##########
@@ -18,22 +18,22 @@
#pragma once
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/olap/task/engine_clone_task.cpp:
##########
@@ -275,7 +274,7 @@ Status EngineCloneTask::_do_clone() {
LOG(INFO) << "clone copy done. src_host: " << src_host.host
<< " src_file_path: " << src_file_path;
- auto tablet_manager = StorageEngine::instance()->tablet_manager();
+ auto tablet_manager = _engine.tablet_manager();
Review Comment:
warning: 'auto tablet_manager' can be declared as 'auto *tablet_manager'
[readability-qualified-auto]
```suggestion
auto *tablet_manager = _engine.tablet_manager();
```
##########
be/test/testutil/run_all_tests.cpp:
##########
@@ -24,6 +24,7 @@
#include "common/config.h"
Review Comment:
warning: 'common/config.h' file not found [clang-diagnostic-error]
```cpp
#include "common/config.h"
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
