github-actions[bot] commented on code in PR #30269:
URL: https://github.com/apache/doris/pull/30269#discussion_r1463077330


##########
be/src/vec/functions/function_ip.h:
##########
@@ -343,7 +336,8 @@ class FunctionIPv6NumToString : public IFunction {
 };
 
 namespace detail {
-template <IPExceptionMode exception_mode, typename ToColumn = ColumnIPv6, 
typename StringColumnType>
+template <IPConvertExceptionMode exception_mode, typename ToColumn = 
ColumnIPv6,
+          typename StringColumnType>

Review Comment:
   warning: function 'convertToIPv6' exceeds recommended size/complexity 
thresholds [readability-function-size]
   ```cpp
   ColumnPtr convertToIPv6(const StringColumnType& string_column,
             ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/vec/functions/function_ip.h:339:** 136 lines including whitespace 
and comments (threshold 80)
   ```cpp
   ColumnPtr convertToIPv6(const StringColumnType& string_column,
             ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to