github-actions[bot] commented on code in PR #30490:
URL: https://github.com/apache/doris/pull/30490#discussion_r1469087443
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -51,66 +51,72 @@
namespace doris::cloud {
using namespace ErrorCode;
-static bvar::LatencyRecorder g_get_rowset_latency("doris_CloudMetaMgr",
"get_rowset");
+namespace {
+constexpr int kBrpcRetryTimes = 3;
-static constexpr int BRPC_RETRY_TIMES = 3;
+static bvar::LatencyRecorder _get_rowset_latency("doris_CloudMetaMgr",
"get_rowset");
Review Comment:
warning: '_get_rowset_latency' is a static definition in anonymous
namespace; static is redundant here
[readability-static-definition-in-anonymous-namespace]
```suggestion
bvar::LatencyRecorder _get_rowset_latency("doris_CloudMetaMgr",
"get_rowset");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
