morrySnow commented on code in PR #30704:
URL: https://github.com/apache/doris/pull/30704#discussion_r1475584930
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FillUpMissingSlots.java:
##########
@@ -183,10 +183,14 @@ static class Resolver {
private final List<Expression> groupByExpressions;
private final Map<Expression, Slot> substitution = Maps.newHashMap();
private final List<NamedExpression> newOutputSlots =
Lists.newArrayList();
+ private final Map<Slot, Expression> outputSubstitutionMap;
Resolver(Aggregate aggregate) {
outputExpressions = aggregate.getOutputExpressions();
groupByExpressions = aggregate.getGroupByExpressions();
+ outputSubstitutionMap =
outputExpressions.stream().filter(Alias.class::isInstance)
+ .collect(Collectors.toMap(alias -> alias.toSlot(), alias
-> alias.child(0),
+ (k1, k2) -> k1));
Review Comment:
use foreach(outputSubstitutionMap.put(alias -> alias.toSlot(), alias ->
alias.child(0)))
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FillUpMissingSlots.java:
##########
@@ -183,10 +183,14 @@ static class Resolver {
private final List<Expression> groupByExpressions;
private final Map<Expression, Slot> substitution = Maps.newHashMap();
private final List<NamedExpression> newOutputSlots =
Lists.newArrayList();
+ private final Map<Slot, Expression> outputSubstitutionMap;
Review Comment:
```suggestion
private final Map<Slot, Expression> outputSubstitutionMap =
Maps.newHashMap();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
