liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477171446
##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,59 @@ class FunctionStringParseUrl : public IFunction {
}
};
+class FunctionUrlDecode : public IFunction {
+public:
+ static constexpr auto name = "url_decode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlDecode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block,
+
+ const ColumnNumbers& arguments, size_t result,
+ size_t input_rows_count) const override {
+ auto null_map = ColumnUInt8::create(input_rows_count, 0);
+ auto& null_map_data = null_map->get_data();
+
+ auto res = ColumnString::create();
+ auto& res_offsets = res->get_offsets();
+ auto& res_chars = res->get_chars();
+ res_offsets.resize(input_rows_count);
+
+ ColumnPtr argument_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto* url_col =
check_and_get_column<ColumnString>(argument_column.get());
+
+ if (!url_col) {
+ return Status::InternalError("Not supported input argument type");
+ }
+
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ if (null_map_data[i]) {
Review Comment:
> this check is seems error: null_map_data it's from null_map, this is your
create local variables and all data is 0?
Yes, it was redundant and I got rid of it. Thank you for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
