AshinGau commented on code in PR #30746:
URL: https://github.com/apache/doris/pull/30746#discussion_r1477968497
##########
be/src/vec/exec/scan/scanner_context.h:
##########
@@ -58,6 +58,47 @@ class VScanNode;
class ScannerScheduler;
class SimplifiedScanScheduler;
+class ScanTask {
+public:
+ ScanTask(std::weak_ptr<ScannerDelegate> delegate_scanner,
vectorized::BlockUPtr free_block)
+ : scanner(delegate_scanner), current_block(std::move(free_block))
{}
+
+private:
+ // whether current scanner is finished
+ bool eos = false;
+ Status status = Status::OK();
+
+public:
+ std::weak_ptr<ScannerDelegate> scanner;
+ // cache the block of current loop
+ vectorized::BlockUPtr current_block;
+ // only take the size of the first block as estimated size
+ bool first_block = true;
+ uint64_t last_submit_time; // nanoseconds
+
+ void set_status(Status _status) {
+ if (_status.is<ErrorCode::END_OF_FILE>()) {
+ // set `eos` if `END_OF_FILE`, don't take `END_OF_FILE` as error
+ eos = true;
+ }
+ status = _status;
+ }
+ Status get_status() const { return status; }
+ bool status_ok() { return status.ok() ||
status.is<ErrorCode::END_OF_FILE>(); }
+ bool is_eos() const { return eos; }
+ void set_eos(bool _eos) { eos = _eos; }
+
+ // reuse current running scanner
+ // reset `eos` and `status`
+ // `first_block` is used to update `_free_blocks_memory_usage`, and take
the first block size
+ // as the `_estimated_block_size`. It has updated
`_free_blocks_memory_usage`, so don't reset.
+ void reuse_scanner(std::weak_ptr<ScannerDelegate> next_scanner) {
+ scanner = next_scanner;
Review Comment:
`first_block` is used to update `_free_blocks_memory_usage`, and take the
first block size. No need to update `_free_blocks_memory_usage` when reusing
`current_block`.
`last_submit_time` is updated in `ScannerScheduler::submit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
