yangzhg commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-doris/pull/6625#discussion_r708969975
##########
File path: be/src/olap/hll.h
##########
@@ -124,33 +125,36 @@ class HyperLogLog {
// Check if input slice is a valid serialized binary of HyperLogLog.
// This function only check the encoded type in slice, whose complex
- // function is O(1).
+ // function is O(1).
static bool is_valid(const Slice& slice);
// only for debug
std::string to_string() {
switch (_type) {
- case HLL_DATA_EMPTY:
- return {};
- case HLL_DATA_EXPLICIT:
- case HLL_DATA_SPARSE:
- case HLL_DATA_FULL: {
- std::string str{"hash set size: "};
- str.append(std::to_string(_hash_set.size()));
- str.append("\ncardinality:\t");
- str.append(std::to_string(estimate_cardinality()));
- str.append("\ntype:\t");
- str.append(std::to_string(_type));
- return str;
- }
- default:
- return {};
+ case HLL_DATA_EMPTY:
Review comment:
case statement does not need to be indented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
