zclllyybb commented on code in PR #31163:
URL: https://github.com/apache/doris/pull/31163#discussion_r1496178190
##########
be/src/vec/columns/column.h:
##########
@@ -366,19 +353,11 @@ class IColumn : public COW<IColumn> {
/// null_data to mark whether need to do hash compute, null_data == nullptr
/// means all element need to do hash function, else only *null_data != 0
need to do hash func
/// do xxHash here, faster than other hash method
- virtual void update_hashes_with_value(std::vector<SipHash>& hashes,
- const uint8_t* __restrict null_data
= nullptr) const {
- LOG(FATAL) << get_name() << " update_hashes_with_value siphash not
supported";
- }
/// Update state of hash function with value of n elements to avoid the
virtual function call
/// null_data to mark whether need to do hash compute, null_data == nullptr
/// means all element need to do hash function, else only *null_data != 0
need to do hash func
/// do xxHash here, faster than other sip hash
- virtual void update_hashes_with_value(uint64_t* __restrict hashes,
Review Comment:
Don't delete this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
