HHoflittlefish777 commented on code in PR #32098:
URL: https://github.com/apache/doris/pull/32098#discussion_r1521002433
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java:
##########
@@ -741,7 +750,8 @@ public boolean hasMoreDataToConsume(UUID taskId,
Map<Integer, Long> partitionIdT
// all offsets to be consumed are newer than offsets in
cachedPartitionWithLatestOffsets,
// maybe the cached offset is out-of-date, fetch from kafka server
again
List<Pair<Integer, Long>> tmp = KafkaUtil.getLatestOffsets(id,
taskId, getBrokerList(),
- getTopic(), getConvertedCustomProperties(),
Lists.newArrayList(partitionIdToOffset.keySet()));
+ getTopic(),
getConvertedCustomProperties(Tag.VALUE_DEFAULT_TAG),
Review Comment:
Is always Tag.VALUE_DEFAULT_TAG?
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java:
##########
@@ -741,7 +750,8 @@ public boolean hasMoreDataToConsume(UUID taskId,
Map<Integer, Long> partitionIdT
// all offsets to be consumed are newer than offsets in
cachedPartitionWithLatestOffsets,
// maybe the cached offset is out-of-date, fetch from kafka server
again
List<Pair<Integer, Long>> tmp = KafkaUtil.getLatestOffsets(id,
taskId, getBrokerList(),
- getTopic(), getConvertedCustomProperties(),
Lists.newArrayList(partitionIdToOffset.keySet()));
+ getTopic(),
getConvertedCustomProperties(Tag.VALUE_DEFAULT_TAG),
Review Comment:
Is it always Tag.VALUE_DEFAULT_TAG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
