englefly commented on code in PR #32210:
URL: https://github.com/apache/doris/pull/32210#discussion_r1524295400
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalPlan.java:
##########
@@ -135,10 +135,7 @@ public boolean pushDownRuntimeFilter(CascadesContext
context, IdGenerator<Runtim
} else {
// null safe equal runtime filter only support bloom filter
Review Comment:
remove this comment please
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalPlan.java:
##########
@@ -135,10 +135,7 @@ public boolean pushDownRuntimeFilter(CascadesContext
context, IdGenerator<Runtim
} else {
// null safe equal runtime filter only support bloom filter
EqualPredicate eq = (EqualPredicate)
builderNode.getHashJoinConjuncts().get(exprOrder);
- if (eq instanceof NullSafeEqual && type ==
TRuntimeFilterType.IN_OR_BLOOM) {
- type = TRuntimeFilterType.BLOOM;
- }
- if (eq instanceof NullSafeEqual && type !=
TRuntimeFilterType.BLOOM) {
+ if (eq instanceof NullSafeEqual || type ==
TRuntimeFilterType.BITMAP) {
Review Comment:
do not need this "if"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
