Gabriel39 commented on a change in pull request #6996:
URL: https://github.com/apache/incubator-doris/pull/6996#discussion_r741591615
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/Load.java
##########
@@ -758,6 +764,22 @@ public static void checkAndCreateSource(Database db,
DataDescription dataDescrip
// do nothing
}
+ } else if (!column.isVisible()) {
+ /*
+ * For batch delete table add hidden column
__DORIS_DELETE_SIGN__ to columns
+ * eg:
+ * (A, B, C)
+ * ->
+ * (A, B, C) SET (__DORIS_DELETE_SIGN__ = 0)
+ */
+ columnToHadoopFunction.put(column.getName(),
Pair.create("default_value", Lists.newArrayList("0")));
+ ImportColumnDesc importColumnDesc = null;
+ try {
+ importColumnDesc = new
ImportColumnDesc(column.getName(), new FunctionCallExpr("default_value",
Arrays.asList(column.getDefaultValueExpr())));
Review comment:
I think it's better to extract `default_value ` to a common constant to
decrease hard code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
