github-actions[bot] commented on code in PR #32299:
URL: https://github.com/apache/doris/pull/32299#discussion_r1525979381
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -471,11 +470,9 @@
LOG(INFO) << "GroupCommitMgr is stopped";
}
-Status GroupCommitMgr::get_first_block_load_queue(int64_t db_id, int64_t
table_id,
- int64_t base_schema_version,
- const UniqueId& load_id,
-
std::shared_ptr<LoadBlockQueue>& load_block_queue,
- int be_exe_version) {
+Status GroupCommitMgr::get_first_block_load_queue(
Review Comment:
warning: method 'get_first_block_load_queue' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/group_commit_mgr.h:168:
```diff
- Status get_first_block_load_queue(int64_t db_id, int64_t table_id,
int64_t base_schema_version,
+ static Status get_first_block_load_queue(int64_t db_id, int64_t
table_id, int64_t base_schema_version,
```
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -228,7 +228,7 @@ Status GroupCommitTable::get_first_block_load_queue(
std::to_string(_table_id));
}
-Status GroupCommitTable::_create_group_commit_load(int be_exe_version) {
+Status GroupCommitTable::_create_group_commit_load() {
Review Comment:
warning: function '_create_group_commit_load' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status GroupCommitTable::_create_group_commit_load() {
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/group_commit_mgr.cpp:230:** 89 lines including whitespace
and comments (threshold 80)
```cpp
Status GroupCommitTable::_create_group_commit_load() {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
