morningman commented on code in PR #32283:
URL: https://github.com/apache/doris/pull/32283#discussion_r1525861145
##########
fe/fe-core/src/main/java/org/apache/doris/fs/remote/dfs/DFSFileSystem.java:
##########
@@ -442,6 +503,16 @@ public Status list(String remotePath, List<RemoteFile>
result, boolean fileNameO
@Override
public Status makeDir(String remotePath) {
- return new Status(Status.ErrCode.COMMON_ERROR, "mkdir is not
implemented.");
+ try {
+ FileSystem fileSystem = nativeFileSystem(remotePath);
+ if (!fileSystem.mkdirs(new Path(remotePath))) {
+ LOG.error("failed to make dir for " + remotePath);
Review Comment:
```suggestion
LOG.warn("failed to make dir for " + remotePath);
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HivePartition.java:
##########
@@ -52,6 +56,15 @@ public HivePartition(String dbName, String tblName, boolean
isDummyPartition,
this.parameters = parameters;
}
+ public HivePartition(String dbName, String tblName, boolean
isDummyPartition,
Review Comment:
Add comment for each constructor the explain the diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
