github-actions[bot] commented on code in PR #31268:
URL: https://github.com/apache/doris/pull/31268#discussion_r1526376582
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1376,13 +1376,19 @@ Status BaseTablet::check_rowid_conversion(
}
// The caller should hold _rowset_update_lock and _meta_lock lock.
-Status BaseTablet::update_delete_bitmap_without_lock(const BaseTabletSPtr&
self,
- const RowsetSharedPtr&
rowset) {
- DBUG_EXECUTE_IF("Tablet.update_delete_bitmap_without_lock.random_failed", {
- if (rand() % 100 < (100 * dp->param("percent", 0.1))) {
-
LOG_WARNING("Tablet.update_delete_bitmap_without_lock.random_failed");
+Status BaseTablet::update_delete_bitmap_without_lock(
Review Comment:
warning: method 'update_delete_bitmap_without_lock' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status BaseTablet::update_delete_bitmap_without_lock(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
