github-actions[bot] commented on code in PR #32128:
URL: https://github.com/apache/doris/pull/32128#discussion_r1528552046
##########
be/src/pipeline/exec/join_probe_operator.cpp:
##########
@@ -82,6 +87,14 @@ template <typename SharedStateArg, typename Derived>
Status JoinProbeLocalState<SharedStateArg, Derived>::_build_output_block(
Review Comment:
warning: function '_build_output_block' has cognitive complexity of 55
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status JoinProbeLocalState<SharedStateArg, Derived>::_build_output_block(
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/join_probe_operator.cpp:89:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!Base::_projections.empty()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:91:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (p._is_outer_join) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:100:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
is_mem_reuse ? vectorized::MutableBlock(output_block)
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:108:** nesting level
increased to 1
```cpp
auto insert_column_datas = [&](auto& to, vectorized::ColumnPtr& from,
size_t rows) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:109:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (to->is_nullable() && !from->is_nullable()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:109:** +1
```cpp
if (to->is_nullable() && !from->is_nullable()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:110:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (keep_origin || !from->is_exclusive()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:110:** +1
```cpp
if (keep_origin || !from->is_exclusive()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:114:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:117:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:118:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (keep_origin || !from->is_exclusive()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:118:** +1
```cpp
if (keep_origin || !from->is_exclusive()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:120:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:125:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (to->is_nullable()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:128:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
for (int i = 0; i < null_column.size(); i++) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:129:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!null_column.is_null_at(i)) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:139:** nesting level
increased to 1
```cpp
auto print = [](vectorized::VExprContextSPtrs& ctxs) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:147:** nesting level
increased to 1
```cpp
auto print_desc = [](std::unique_ptr<RowDescriptor>& desc) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:149:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!desc) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:151:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:166:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (rows != 0) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:168:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (_output_expr_ctxs.empty()) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:171:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
for (int i = 0; i < mutable_columns.size(); ++i) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:175:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:179:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
for (int i = 0; i < mutable_columns.size(); ++i) {
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:181:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_output_expr_ctxs[i]->execute(origin_block,
&result_column_id));
^
```
**be/src/common/status.h:541:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:181:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(_output_expr_ctxs[i]->execute(origin_block,
&result_column_id));
^
```
**be/src/common/status.h:543:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:189:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (is_column_const(*origin_column) ||
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:189:** +1
```cpp
if (is_column_const(*origin_column) ||
^
```
**be/src/pipeline/exec/join_probe_operator.cpp:193:** +1, nesting level
increased to 4
```cpp
} else {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
